Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliance): add ens for azure and gcp #5746

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Nov 13, 2024

Description

This pull request introduces several changes to enhance the compliance reporting capabilities for Azure and GCP in the prowler project. The most significant changes include the addition of new compliance frameworks for Azure and GCP, updates to the prowler main script to handle these new frameworks, and the creation of corresponding test cases.

Compliance Frameworks Enhancements:

Codebase Updates:

Documentation and Testing:

  • README.md: Updated the compliance frameworks section to reflect the new compliance checks available for Azure and GCP.
  • tests/lib/outputs/compliance/ens/ens_azure_test.py: Added test cases for the AzureENS class to ensure the correct transformation of findings and proper CSV output generation.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot marked this pull request as ready for review November 15, 2024 11:50
@pedrooot pedrooot requested review from a team as code owners November 15, 2024 11:50
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 86.31579% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (f3cfaca) to head (fef6fc0).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
prowler/__main__.py 0.00% 12 Missing ⚠️
prowler/lib/outputs/compliance/ens/ens.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   89.89%   89.88%   -0.02%     
==========================================
  Files        1128     1134       +6     
  Lines       35182    35369     +187     
==========================================
+ Hits        31628    31790     +162     
- Misses       3554     3579      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant